Skip to content

incus: do not let an install script block on an invisible prompt #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MickLesk merged 1 commit into from
Sep 25, 2026
Merged

incus: do not let an install script block on an invisible prompt #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion incus/backend.func
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,12 +1063,14 @@ INNEREOF" >>"${LOGFILE:-$INCUS_BUILD_LOG}" 2>&1 || { msg_error "Failed to push f
# reported as a success against an empty container.
set +Eeuo pipefail
trap - ERR
# stdin from /dev/null: without a pty `read -p` prints no prompt at all, so a
# script that asks a question waited on input nobody could see or answer.
# The trailing touch is a completion sentinel: all 552 install scripts run to
# cleanup_lxc/customize and none exits early, so the marker appears if and
# only if the script reached its end.
incus exec "${CT_NAME}" -- bash -c "${_run_env}
${_install_script}
touch /root/.install-${SESSION_ID}.done" 2>&1 |
touch /root/.install-${SESSION_ID}.done" </dev/null 2>&1 |
tee >(sed -u 's/.*\r//' >>"${LOGFILE:-$INCUS_BUILD_LOG}")
# PIPESTATUS, not $?: the line above turns pipefail off, so $? is tee's
# status - always 0. Every non-zero exit from the container was discarded
Expand Down
Loading