refactor(runtime): timer - #995
Open
George-Miao wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
enhancement
George-Miao
force-pushed
the
refactor/runtime/timer
branch
4 times, most recently
from
August 3, 2026 03:27
3b31b1f to
882f1f7
Compare
George-Miao
force-pushed
the
refactor/runtime/timer
branch
from
August 3, 2026 03:38
882f1f7 to
3826863
Compare
Berrysoft
previously approved these changes
Aug 3, 2026
Berrysoft
requested changes
Aug 3, 2026
George-Miao
enabled auto-merge (squash)
August 3, 2026 22:54
Berrysoft
reviewed
Aug 4, 2026
| Err(payload) => { | ||
| // Pending tasks must be cleared after the active unwind has | ||
| // ended so their futures can be dropped safely. | ||
| self.enter(|| self.executor.clear()); |
Member
There was a problem hiding this comment.
What if we spawn a future in the first block_on calling, and await the JoinHandle in the second block_on?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.