GHA: cross-compile Android on Linux instead of Windows - #248
Merged
Conversation
windows-latest builds noticeably slower than ubuntu-latest for this kind of CMake/Ninja/clang workload (per-file AV scanning, slower NTFS metadata operations), and this job's only reason for running on Windows was to also prove the Windows-host NDK cross-compile path. That coverage is redundant: ds2 on Windows is already exercised by the native windows/windows_arm64/windows_store/mingw build jobs and test-windows, so nothing is lost by moving this to Linux. Dropping the pre-built regsgen2.exe dependency along with it: the windows_tools artifact existed to share one regsgen2 build across all the Windows jobs, but on Linux, omitting DS2_REGSGEN2 lets CMake build RegsGen2 itself via ExternalProject against the host compiler, the same way the existing Linux job already does for its own cross builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-latest builds noticeably slower than ubuntu-latest for this kind of CMake/Ninja/clang workload (per-file AV scanning, slower NTFS metadata operations), and this job's only reason for running on Windows was to also prove the Windows-host NDK cross-compile path. That coverage is redundant: ds2 on Windows is already exercised by the native windows/windows_arm64/windows_store/mingw build jobs and test-windows, so nothing is lost by moving this to Linux.
Dropping the pre-built regsgen2.exe dependency along with it: the windows_tools artifact existed to share one regsgen2 build across all the Windows jobs, but on Linux, omitting DS2_REGSGEN2 lets CMake build RegsGen2 itself via ExternalProject against the host compiler, the same way the existing Linux job already does for its own cross builds.