chore: clean up stale and redundant comments - #91
Merged
Conversation
leoafarias
marked this pull request as ready for review
August 21, 2026 20:56
Co-authored-by: Cursor <cursoragent@cursor.com>
tnramalho
reviewed
Aug 24, 2026
|
|
||
| /** | ||
| * Persistence configuration passed on `RocketsAuthOptionsExtrasInterface`. | ||
| * Persistence for {@link DefineRocketsAuthInput.persistence}. |
Collaborator
There was a problem hiding this comment.
This link does not resolve in TypeDoc: DefineRocketsAuthInput.persistence. Use plain text for .persistence, or link only DefineRocketsAuthInput and name the property outside the link.
Collaborator
There was a problem hiding this comment.
Fixed in c95df1b: the link now targets DefineRocketsAuthInput and leaves persistence as plain property text. Verified the specific TypeDoc warning is gone.
tnramalho
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Removes redundant, stale, and implementation-narrating comments across Rockets core, server auth, tests, and examples while retaining concise rationale where it helps explain behavior.
Changes
Type of Change
Verification
yarn build)yarn test)yarn test:e2e) — aggregate run had one unrelated 404 increate-server.e2e-spec.ts; the exact spec passes alone (3/3)yarn lint)yarn api:report:check-built)yarn typecheck:spec)Checklist