Fix slow tag ancestors#472
Open
C85297 wants to merge 1 commit intoconcourse:masterfrom
Open
Conversation
|
Contributor
Author
|
It seems EasyCLA will require me to get a corporate CLA approval completed, this may take a while :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #437 I added the
match_tag_ancestorsfeature to return commits that were ancestors of matching tags.That initial implementation turned out to be poorly optimised, and in large repos with many tags and many commits, a nested loop over each commit and each tag becomes very slow.
This pull request optimises the
match_tag_ancestorsfeature:git tag --containsto get a list of tags the commit is an ancestor of, and check if any of those tags match the eligible tags we're looking for.My testing showed around 100x less subprocesses spawned and 40x faster check runs.