Skip to content

Add linux-riscv64 as a cross-compilation target - #105

Closed
luhenry wants to merge 10 commits into
conda-forge:mainfrom
luhenry:velonica0/main
Closed

Add linux-riscv64 as a cross-compilation target#105
luhenry wants to merge 10 commits into
conda-forge:mainfrom
luhenry:velonica0/main

Conversation

@luhenry

@luhenry luhenry commented Aug 14, 2026

Copy link
Copy Markdown
  • linux-riscv64
  • Fix CI under current rattler-build
  • Add license_file to satisfy the linter
  • MNT: Re-rendered with conda-smithy 2026.8.9 and conda-forge-pinning 2026.08.13.08.26.4
  • Build linux-aarch64 natively
  • MNT: Re-rendered with conda-smithy 2026.8.9 and conda-forge-pinning 2026.08.13.08.26.46

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ 'Store Build Artifacts' is deprecated.
    Deprecated. Store the conda build_artifacts directory as an Azure pipeline artifact. Use workflow_settings.store_build_artifacts instead.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/31819348548. Examine the logs at this URL for more detail.

…026.08.13.08.26.46

Other tools:
- conda-build 26.7.0
- rattler-build 0.72.2
- rattler-build-conda-compat 1.4.19
@luhenry
luhenry marked this pull request as ready for review August 14, 2026 16:31
…026.08.13.08.26.46

Other tools:
- conda-build 26.7.0
- rattler-build 0.72.2
- rattler-build-conda-compat 1.4.19
@luhenry

luhenry commented Aug 14, 2026

Copy link
Copy Markdown
Author

@conda-forge/cross-python this passes all CI and should be good to go. It supersedes #104. PTAL, thank you! :)

@h-vetinari

Copy link
Copy Markdown
Member

It supersedes #104.

No, it doesn't, at least not without coordination. It's fair to pick up long-dead PRs, or anything from the bot, but don't take a PR from an active contributor and then claim yours supersedes it (unless that contributor tell you to go ahead after being somehow not in a position to make your suggested changes themselves, or at least as quickly as you).

Also, if you do pick up any other PR, please give it a different title. It gets very confusing to receive notifications from different PRs on the same feedstock that only differ in the PR number. I usually use <title> (redux), but you can do <title>, take 2 or whatever suits your fancy.

@luhenry

luhenry commented Aug 14, 2026

Copy link
Copy Markdown
Author

It supersedes #104.

No, it doesn't, at least not without coordination. It's fair to pick up long-dead PRs, or anything from the bot, but don't take a PR from an active contributor and then claim yours supersedes it (unless that contributor tell you to go ahead after being somehow not in a position to make your suggested changes themselves, or at least as quickly as you).

Also, if you do pick up any other PR, please give it a different title. It gets very confusing to receive notifications from different PRs on the same feedstock that only differ in the PR number. I usually use <title> (redux), but you can do <title>, take 2 or whatever suits your fancy.

I'm sorry, I indeed shouldn't have, my bad. I will submit the Build osx-arm64 natively separately.

@luhenry luhenry closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants