build-dm-verity-task: make the labels a parameter to the task#174
build-dm-verity-task: make the labels a parameter to the task#174littlejawa wants to merge 1 commit into
Conversation
|
/cc @snir911 @dbkreling This should help in the general case (making a new release should not involve modifying the build task). Keeping it as a draft for now, I want to double-check the resulting image. |
littlejawa
force-pushed
the
make_labels_a_parameter_to_the_task
branch
3 times, most recently
from
ecfb010 to
5d6a96f
Compare
|
/retest |
littlejawa
force-pushed
the
make_labels_a_parameter_to_the_task
branch
from
bf37a29 to
f670966
Compare
|
Verified using the "debug" image generated with this PR (the "normal" version is still using the previous build task). |
|
/retest |
1 similar comment
|
/retest |
The task currently has hardcoded labels that it applies to the image. Part of them contain the release version in it, forcing us to modify/rebuild the task every time we make a new release. It also means that a given task cannot be used for different releases. This commit moves the list of labels to a parameter to the task, and modify the build script to loop on that list and apply them one by one. It also modifies the dm-verity build pipelines to provide this list as intended. Similar changes are applied to the debug flavor of the build task and pipelines, for consistency. Signed-off-by: Julien Ropé <jrope@redhat.com>
littlejawa
force-pushed
the
make_labels_a_parameter_to_the_task
branch
from
f670966 to
dc12a47
Compare
|
@snir911 @dbkreling Can we merge this one? |
2 participants
The task currently has hardcoded labels that it applies to the image. Part of them contain the release version in it, forcing us to modify/rebuild the task every time we make a new release. It also means that a given task cannot be used for different releases.
This commit moves the list of labels to a parameter to the task, and modify the build script to loop on that list and apply them one by one. It also modifies the dm-verity build pipelines to provide this list as intended.
Similar changes are applied to the debug flavor of the build task and pipelines, for consistency.