chore: add E2E tests for Flink UDFs#3386
Open
Dave Shoup (shouples) wants to merge 13 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Playwright E2E coverage for Flink UDF user flows and introduces a reusable Playwright fixture to create/clean up Flink artifacts (to reduce leaked test resources), along with small supporting updates to tags/CI defaults and accessibility labeling needed for stable selectors.
Changes:
- Added new E2E specs covering guided UDF creation, SQL registration document generation, and UDF deletion (parameterized by cloud provider/region).
- Introduced an
artifactPlaywright fixture (plusArtifactConfigtyping) to upload an artifact for a test and delete it afterward. - Added a new
@flink-udfstag and included it in default CI E2E tag sets; added an accessibility label for Flink UDF tree items.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/types/artifact.ts | Adds ArtifactConfig type for configuring artifact fixture behavior. |
| tests/e2e/tags.ts | Introduces Tag.FlinkUDFs (@flink-udfs). |
| tests/e2e/specs/flinkUdf.spec.ts | New E2E tests for UDF create/open-SQL-template/delete flows. |
| tests/e2e/objects/views/FlinkDatabaseView.ts | Adds UDF-related view helpers; refactors artifact deletion to use search-based lookup. |
| tests/e2e/baseTest.ts | Adds artifactConfig option + artifact fixture with upload + teardown deletion behavior. |
| src/models/flinkUDF.ts | Adds accessibilityInformation.label for UDF tree items (enables stable aria-label selectors). |
| service.yml | Adds @flink-udfs to default E2E tag sets. |
| .semaphore/semaphore.yml | Adds @flink-udfs to default E2E tag sets for Semaphore promotions. |
|
airlock-confluentinc
Bot
force-pushed
the
djs/e2e-flink-udfs
branch
from
fd942d2 to
7da14b0
Compare
Dave Shoup (shouples)
changed the base branch from
main
to
djs/flink-view-progress-fix
…gistration/deletion
Co-authored-by: Copilot <copilot@github.com>
airlock-confluentinc
Bot
force-pushed
the
djs/e2e-flink-udfs
branch
from
c1c3e87 to
a261c23
Compare
|
Noel Cothren (noeldevelops)
approved these changes
Jun 29, 2026
Noel Cothren (noeldevelops)
left a comment
Noel Cothren (noeldevelops)
left a comment
Member
There was a problem hiding this comment.
looks good ✅✅✅✅✅✅✅
| // server-side cleanup: if the happy-path test didn't reach its inline delete | ||
| // (e.g. an earlier assertion failed), drop the orphaned artifact here so | ||
| // reruns don't pile up dangling artifacts on the cluster. Best-effort: a | ||
| // failed cleanup must not mask the original test failure, hence the catch. |
Comment on lines
+104
to
+106
| * Configuration options for creating an artifact with the {@linkcode artifact} fixture. | ||
| */ | ||
| artifactConfig: ArtifactConfig | undefined; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Sample run: https://semaphore.ci.confluent.io/workflows/fe780ab0-c8d1-4314-8be7-127b44de7217?pipeline_id=9b07a948-933a-4cfd-9ec5-17047030507c
Closes #2482, and also closes #3110 by setting up the
artifactplaywright fixture.Pull request checklist
Please check if your PR fulfills the following (if applicable):
Tests
Release notes