[LucaCappelletti94]

apache/datafusion-sqlparser-rs#2679 merged Expr::InList, Expr::InSubquery and Expr::InUnnest into one Expr::In whose target is an InTarget. sql-traits follows it since connetto-rs/sql-traits#110, so every fresh build of pg2sqlite has stopped compiling, on main and on every open pull request.

Each match and construction now uses Expr::In with the InTarget its old variant stood for. Where only subqueries were handled specially, the arm matches InTarget::Subquery and lists and UNNEST still reach the default arm, so translation is unchanged.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Central YAML; Path: .coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 2bc28977-0110-4253-9001-e6ce1b4ab9e1

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.91%. Comparing base (aead6de) to head (83c4b29).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/impls/expr_helpers.rs	81.81%	2 Missing ⚠️
src/impls/translator_impls/expr.rs	93.10%	2 Missing ⚠️
src/impls/replay.rs	0.00%	1 Missing ⚠️
src/impls/reverse_translator_impls/expr.rs	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   92.90%   92.91%   +0.01%     
==========================================
  Files          67       67              
  Lines       28723    28716       -7     
==========================================
- Hits        26684    26682       -2     
+ Misses       2039     2034       -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.