Repository navigation
Merge a parenthesized query with the clauses around it - #147
Merged
Merged
Conversation
PostgreSQL treats the clauses around a parenthesized query as clauses of that query, so `(SELECT 0)` runs and `(SELECT a FROM q ORDER BY id LIMIT 2) OFFSET 1` is one query with `LIMIT 2 OFFSET 1`. SQLite has no parenthesized query, so the output failed with `near "("`, at the statement root and inside a derived table alike.
The translator now merges a directly nested query body with its outer clauses before translating it. A clause given on both sides is refused with PostgreSQL's own `multiple ... clauses not allowed`, since sqlparser accepts what PostgreSQL rejects. Compound operands keep their existing handling.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL treats the clauses around a parenthesized query as clauses of that query, so
(SELECT 0)runs and(SELECT a FROM q ORDER BY id LIMIT 2) OFFSET 1is one query withLIMIT 2 OFFSET 1. SQLite has no parenthesized query, so the output failed withnear "(", at the statement root and inside a derived table alike.The translator now merges a directly nested query body with its outer clauses before translating it. A clause given on both sides is refused with PostgreSQL's own
multiple ... clauses not allowed, since sqlparser accepts what PostgreSQL rejects. Compound operands keep their existing handling.