Repository navigation
Quote identifiers that SQLite reserves - #148
Merged
Merged
Conversation
PostgreSQL lets a source name a table, column or alias with words such as `set`, `values` or a bare `not`, and the forward output kept them bare, which SQLite rejects as a syntax error. `CREATE TABLE t (id int, set int, values int)` already failed in its own DDL. The finished script now double-quotes every unquoted identifier among the keywords SQLite 3.51.1 refuses as a bare name, lowercased the way PostgreSQL folds it. Function names stay bare because the translator emits `RAISE(IGNORE)`, and `DEFAULT` stays bare because SQLite would read it as a string once quoted. The pass runs once over the whole script, so replayed and rebound forms are covered too.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL lets a source name a table, column or alias with words such as
set,valuesor a barenot, and the forward output kept them bare, which SQLite rejects as a syntax error.CREATE TABLE t (id int, set int, values int)already failed in its own DDL.The finished script now double-quotes every unquoted identifier among the keywords SQLite 3.51.1 refuses as a bare name, lowercased the way PostgreSQL folds it. Function names stay bare because the translator emits
RAISE(IGNORE), andDEFAULTstays bare because SQLite would read it as a string once quoted. The pass runs once over the whole script, so replayed and rebound forms are covered too.