Repository navigation
Run refquiem 0.3.0 with the PostgreSQL and SQLite function vocabularies - #165
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the refquiem review to 0.3.0 and selects its
postgres@18andsqlite@3.54vocabularies next toenglish, so a SQL function the translator maps between no longer reads as a removed Rust item of the same name.A full-history scan of main reported 24 such mentions, all as functions of the removed
translator_impls::uuidmodule. They are SQLite'sunhex(14) andprintf(6) in doc comments, and PostgreSQL'sbit_andandbit_or(4) in test SQL. With both vocabularies the scan drops exactly those and finds nothing new.The action's inputs are the same in 0.3.0, so only the pinned revision and the installed version change.