Skip to content

Drop REVOKE role FROM role with the access-control warning - #174

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
upstream/revoke-role
Oct 28, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
upstream/revoke-role

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Collaborator

sqlparser main now parses REVOKE role FROM grantee as Statement::RevokeRole (apache/datafusion-sqlparser-rs#2735). The statement match in statement.rs has no wildcard arm, so pg2sqlite stopped compiling against it, and CI fails on every branch until this lands.

A membership revoke now drops with the same access-control warning as a privilege REVOKE, the way #170 folded GrantRole into the GRANT arm. Withdrawing the membership from the role catalog that row-level security reads is connetto-rs/sql-traits#175.

@LucaCappelletti94 LucaCappelletti94 added the bug Something isn't working label Oct 28, 2026
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LucaCappelletti94
LucaCappelletti94 merged commit 761bee3 into main Oct 28, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant