Repository navigation
Translate DROP FOREIGN TABLE and refuse it with CASCADE - #184
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparser
maingainedObjectType::ForeignTablewith apache/datafusion-sqlparser-rs#2746, and pg2sqlite matchesObjectTypeexhaustively indrop_labeland in theStatement::Droparm, so the crate no longer builds against sqlparsermain.CREATE FOREIGN TABLEis already dropped with a foreign data warning (#106), so a plainDROP FOREIGN TABLEremoves nothing that exists in the SQLite output and joinsDROP SEQUENCEandDROP TYPEas a warned drop. WithCASCADEit is refused instead. A view that reads a foreign table still reaches the output, and PostgreSQL deletes that view along with the table, so a warned drop would leave the replica holding a view the source no longer has. This mirrors the refusal of a cascadingDROP SCHEMA.COMMENT ON FOREIGN TABLEneeded no change because everyCOMMENTis already a warned drop, and the statement outcome corpus now covers it.