Skip to content

Match sqlparser's merged Expr::In membership variant - #25

Merged
LucaCappelletti94 merged 2 commits into
mainfrom
upstream/current-parser-in-predicates
Oct 22, 2026
Merged

LucaCappelletti94 merged 2 commits into
mainfrom
upstream/current-parser-in-predicates

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Collaborator

Apache sqlparser merged Expr::InList, Expr::InSubquery and Expr::InUnnest into one Expr::In whose target is an InTarget (apache/datafusion-sqlparser-rs#2679). This crate follows parser main, so it no longer compiled, which also blocks the replay coverage work in subql.

The canonicalizer now matches Expr::In once and branches on the target. Lists and subqueries produce the same canonical text and stable hashes as before, with GLOBAL and NOT kept apart, and IN UNNEST is refused before its operand is read. The test oracle takes the same shape, and both lockfiles move to parser main at d9eec6e.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b40dfc0a-760b-4f28-945d-638a6d2db8dd
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (6a0cd75) to head (cf8d9b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   97.55%   97.55%   -0.01%     
==========================================
  Files           1        1              
  Lines        1187     1184       -3     
==========================================
- Hits         1158     1155       -3     
  Misses         29       29              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 merged commit 3d16944 into main Oct 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant