feat: add status field to RequestUploadUrlPayload#1034
Merged
pyramation merged 3 commits intomainfrom Apr 29, 2026
Merged
Conversation
Return the file status in requestUploadUrl responses so clients can immediately determine whether a deduplicated file is usable: - deduplicated files: status is 'ready' or 'processed' (from DB) - fresh uploads: status is 'pending' (awaiting PUT + confirmUpload) Changes: - graphile-presigned-url-plugin: add status to GraphQL schema, TS type, and both dedup/fresh return paths - upload-client: add status to query string, types, and use server value instead of hard-coding 'ready' for dedup - Tests: update all mock fixtures and add status assertions
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
statusfield toRequestUploadUrlPayloadso clients know immediately whether a file is usable after deduplication.statusreturns the actual value from the DB ('ready'or'processed')statusreturns'pending'Changes span the Graphile plugin (
plugin.ts,types.ts), upload-client (types.ts,queries.ts,upload.ts), and both snapshot files (graphile-test,server-test).The
upload-clientpreviously hardcodedstatus: 'ready'for dedup cases — now it correctly passes through the server's response.Review & Testing Checklist for Human
statusfield appears correctly in GraphQL playground/explorerstatus: 'ready'(not'pending')uploadFile()from@constructive-io/upload-clientreturns correct status for both fresh and dedup casesNotes
server-testschema snapshot that caused the initial CI failure"
Link to Devin session: https://app.devin.ai/sessions/58b40b3f63804c20b86643cc873ba844
Requested by: @pyramation