Repository navigation
Conversation
Signatures made through the Python SDK could not carry rVals.ocspVals, so validators had to fetch revocation status themselves. with_ocsp_response binds c2pa_signer_with_ocsp_response, swapping in the stapling signer in place so callback lifetimes and chaining work as before. Requires a native library that exports the new function.
3 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds
Signer.with_ocsp_response(ocsp_response), which staples a DER-encoded OCSP response into every signature the signer produces. Call it once per certificate along the chain, signing certificate first. It binds the new C functionc2pa_signer_with_ocsp_response; on failure the signer is unchanged and still usable.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.