Repository navigation
feat(cms): render tab paragraph through the editable paragraph renderer (DX-31557) - #28
Merged
vaishnavi-kedar-cstk merged 2 commits intoOct 28, 2026
Conversation
Register CMSTabParagraphComponent to ContentstackEditableParagraphComponent beside CMSParagraphComponent so tab paragraphs get the same markup and the preview-only field-level data-cslp tag. Adds mapper, module-registration and renderer specs (TestBed specs are outside the npm test match). Refs: DX-31557 Co-authored-by: Claude <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
Refs: DX-31557 Co-authored-by: Claude <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
vaishnavi-kedar-cstk
marked this pull request as ready for review
October 28, 2026 10:56
vaishnavi-kedar-cstk
merged commit Oct 28, 2026
dc967b3
into
epic/DX-31554-sap-rich-text-paragraph
10 checks passed
vaishnavi-kedar-cstk
deleted the
claude/feat/DX-31557-tab-paragraph-editable-renderer
branch
October 28, 2026 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DX-31557 · Epic DX-31554 · wave 2 of 2 (after DX-31556, PR #27)
What
CMSTabParagraphComponenttoContentstackEditableParagraphComponentbesideCMSParagraphComponent(decision A-2). The field mapper already passes Content through for both types.''); runs innpm test.testMatch(pod decision DSCDX-743); to be run by hand in the E2E host app.Gate (local): lint 0 errors (54 existing warnings), format:check, typecheck, test:all (177 + 8 tests) pass.
TC-22, tab paragraph vs SAP stock renderer (from code, not run in a browser)
#; ours keeps#sec, which resolves against<base href>.on*handlers are removed (intended).The first two already apply to plain paragraphs.
Risk to check in Visual Builder: tab paragraphs expanded by
expandContainer()in the page normalizer are bare{uid,typeCode}; if the later fetch content type differs from the entry's real type, the previewdata-cslptag could name the wrong type. Not verified.For a person: manual test on the test stack (create a tab paragraph entry, place it in a slot, edit inline on a preview build, publish).
Skipped: nothing.
Generated by Claude Code