Skip to content

fix(starter-pack): add headings to the paragraph rich-text toolbar (DX-31556) - #30

Merged
vaishnavi-kedar-cstk merged 1 commit into
epic/DX-31554-sap-rich-text-paragraphfrom
claude/fix/DX-31556-rte-toolbar-headings
Oct 28, 2026
Merged

vaishnavi-kedar-cstk merged 1 commit into
epic/DX-31554-sap-rich-text-paragraphfrom
claude/fix/DX-31556-rte-toolbar-headings

Conversation

@vaishnavi-kedar-cstk

Copy link
Copy Markdown
Contributor

🤖 Authored by the Dev agent (AI), triggered by Vaishnavi Kedar.

Follow-up to a review comment on #29. DX-31556 AC says authors get headings, bold, lists and links, but the generated options had no headings.

  • Adds h2..h6 to the rich-text options (the copy field in kickstart-stack-seed stack/content_types/page.json uses the same heading options; rich_text uses lists).
  • Field instruction now names the real toolbar; JSON regenerated by the generator (idempotent).
  • TC-1 spec asserts lists and h2..h6; CONTENT-MODEL.md section 3.2 lists the toolbar.

Gate (local): lint 0 errors, format:check, typecheck, test:all pass.


Generated by Claude Code

The paragraph `content` rich-text helper omitted heading options, so the
editor toolbar had no H2-H6. Add h2..h6 to the option set (shape taken from
the `rich_text` and `copy` fields of kickstart-stack-seed page.json), update
the field instruction to name the real toolbar, regenerate the two paragraph
content types, extend the TC-1 spec to assert headings and lists, and document
the toolbar (tables are not in it) in CONTENT-MODEL.md section 3.2.

Refs: DX-31556

Co-authored-by: Claude <noreply@anthropic.com>
@snyk-io

snyk-io Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 2 10 ✅ Passed
🟠 High Severity 0 23 25 ✅ Passed
🟡 Medium Severity 0 18 500 ✅ Passed
🔵 Low Severity 0 1 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 2
  • High without fixes: 23
  • Medium without fixes: 18
  • Low without fixes: 1

✅ BUILD PASSED - All security checks passed

@vaishnavi-kedar-cstk
vaishnavi-kedar-cstk merged commit 86ce024 into epic/DX-31554-sap-rich-text-paragraph Oct 28, 2026
10 checks passed
@vaishnavi-kedar-cstk
vaishnavi-kedar-cstk deleted the claude/fix/DX-31556-rte-toolbar-headings branch October 28, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants