Skip to content

fix: resolve Snyk vulnerabilities in undici and brace-expansion - #72

Closed
cs-raj wants to merge 1 commit into
masterfrom
fix/snyk-patch-deps-20261022
Closed

cs-raj wants to merge 1 commit into
masterfrom
fix/snyk-patch-deps-20261022

Conversation

@cs-raj

@cs-raj cs-raj commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Problem

Snyk reports 21 vulnerabilities (3 critical) on master: 18 in undici@7.29.0, 3 in brace-expansion@5.0.9.

Fix

Library, so the undici floor is raised in package.json and consumers pick up the fix too.

  • undici ^7.29.0 → ^7.30.1
  • dev deps, safe minor: jest ^29.7.0, @types/node 10.17.60, supertest 3.4.2, tslint 5.20.1, typescript ^5.9.3
  • overrides.brace-expansion 5.0.9 → 5.0.12 (our own install only)
  • version 2.3.8 → 2.3.9; lock file regenerated
  • .talismanrc: package-lock.json now ignores filecontent/base64content instead of a checksum that breaks on every regen

Remaining: npm audit still flags jest (fix only in 30.x) and tslint, majors only, not applied.

Snyk 21 → 0, npm audit 34 → 34; npm run build-ts passes. npm test shows the same 8/10 failures as unmodified master.

🤖 Generated with Claude Code

Lock file regenerated (fixed 18 on its own).
Direct upgrades: undici ^7.30.1, jest ^29.7.0, @types/node 10.17.60, supertest 3.4.2, tslint 5.20.1, typescript ^5.9.3
Overrides: brace-expansion 5.0.9 -> 5.0.12
Vuln count: snyk 21 -> 0, npm audit 34 -> 34. Build verified passing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cs-raj
cs-raj requested a review from a team as a code owner October 22, 2026 12:00
@cs-raj cs-raj self-assigned this Oct 22, 2026
@snyk-io

snyk-io Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@cs-raj

cs-raj commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Moved into #71 (back-merge to development) per Raj.

@cs-raj cs-raj closed this Oct 22, 2026
@cs-raj
cs-raj deleted the fix/snyk-patch-deps-20261022 branch October 22, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant