Skip to content

fix: replace hardcoded test API key with placeholder (DX-25848) - #118

Merged
cs-raj merged 1 commit into
developmentfrom
fix/DX-25848-hardcoded-secret
Oct 29, 2026
Merged

cs-raj merged 1 commit into
developmentfrom
fix/DX-25848-hardcoded-secret

Conversation

@cs-raj

@cs-raj cs-raj commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes DX-25848: Snyk Code flagged a Hardcoded Non-Cryptographic Secret (Low) at test/dummy/config.ts:4.

Changes

  • test/dummy/config.ts: replaced apiKey: 'dummyApiKey' with the approved low-entropy placeholder API_KEY, per the Engineering Standard Dummy Secret Values & Scanner Mitigation.
  • Removed the deepcode ignore HardcodedNonCryptoSecret suppression comment (the standard says not to bypass the scanner).

Impact / risk

  • Test fixture only; no change to src/ or published package behavior.
  • The value is not asserted anywhere else. test/index.ts and test/api.ts define their own inline dummyApiKey fixtures and do not read it from this config.

Testing

  • npm test on this branch vs. development: identical suite results, so no regressions from this change. test/api.ts fails on development and passes here (likely flaky, not related).
  • Pre-existing failures on both branches, unrelated to this PR: 9 suites fail to run with "Jest encountered an unexpected token" (src/index.ts:10), plus 4 failing tests in test/util/validations.ts and test/util/fs.ts.
  • Re-run snyk code test to confirm the finding clears.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@cs-raj
cs-raj requested a review from a team as a code owner October 29, 2026 09:25
@snyk-io

snyk-io Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cs-raj
cs-raj merged commit a2fa271 into development Oct 29, 2026
10 checks passed
@cs-raj cs-raj mentioned this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants