Skip to content

fix(variables): reword the manual entry choice, its summary and the unset messages (+Claude) - #253

Merged
Harshi-Shah-CS merged 1 commit into
v2-devfrom
cl-7169
Oct 26, 2026
Merged

Harshi-Shah-CS merged 1 commit into
v2-devfrom
cl-7169

Conversation

@Harshi-Shah-CS

Copy link
Copy Markdown
Contributor

What

Wording feedback on the launch:variables flows (CL-7169):

Where Before After
Checklist choice (create and variables:set) Type KEY=VALUE pairs Manually add custom variables (V1's wording)
Question after that choice KEY=VALUE pairs separated by spaces Enter variables separated by spaces (Ex: KEY1=value1 KEY2:value2 KEY3="value with spaces")
Summary for pairs entered at that prompt ✔ 1 variable set — 1 from --var ✔ 1 variable set — 1 from manual entry (override: KEY overridden by manual entry)
Summary for --var ✔ 1 variable set — 1 from --var unchanged
unset confirmation Are you sure you want to remove DEBUG from "Default"? Are you sure you want to remove the variable DEBUG from the "Default" environment?
unset success ✔ DEBUG removed from Default. ✔ Variable DEBUG removed from the "Default" environment.

The prompt path used to label typed pairs --var, as if the flag had been used. Now only the flag says --var. With several keys, unset says "variables" instead of "variable". Keys keep their case.

Tests

  • Test expectations are updated to the new text. The prompt-path tests now also check that --var doesn't appear, and the --var flag tests still check for 1 from --var.
  • A new case reads the example out of the question itself and checks that it parses into the three pairs it shows. Removing the quotes from the example turns the test red.
  • npm test: 139 suites, 2420 tests pass. Lint and tsc pass.
  • /code-review ran on the change:
    • Fixed: the hint test now reads the real constant and sits in the existing describe block. The unset confirmation was reworded to match the success line.
    • Not changed: the duplicate-key PATCH finding was a false positive, because unsetVariables already deduplicates.

.talismanrc checksums are refreshed for the ten changed files it flags.

#claude_code#
🤖 Generated with Claude Code

…nset messages

Feedback on the variables wording:

- The checklist choice "Type KEY=VALUE pairs" is now "Manually add
  custom variables", V1's wording, in both the create and set
  checklists. Its question is shorter and shows the format by example:
  'Enter variables separated by spaces (Ex: KEY1=value1 KEY2:value2
  KEY3="value with spaces")'. A test reads that example out of the
  question and checks it parses as shown.
- Pairs entered at that prompt were labelled --var in the summary, as if
  the flag had been used. They now read "N from manual entry" and
  "KEY overridden by manual entry"; values given with --var still read
  "N from --var".
- unset now says 'Are you sure you want to remove the variable DEBUG
  from the "Default" environment?' and '✔ Variable DEBUG removed from the
  "Default" environment.', with "variables" for several keys. Keys keep
  their case.

The .talismanrc checksums are refreshed for the ten changed files it
flags (variable keys and prompt text, no secret).

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Sakshi Koli <sakshi.koli@contentstack.com>
@Harshi-Shah-CS
Harshi-Shah-CS requested review from a team as code owners October 26, 2026 12:29
@snyk-io

snyk-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 1 9 25 ✅ Passed
🟡 Medium Severity 0 4 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 9
  • Medium without fixes: 4
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@Harshi-Shah-CS
Harshi-Shah-CS merged commit d86da23 into v2-dev Oct 26, 2026
7 checks passed
@Harshi-Shah-CS
Harshi-Shah-CS deleted the cl-7169 branch October 26, 2026 12:37
SakshiKoli-CS added a commit that referenced this pull request Oct 26, 2026
Brings in #253 (the variables manual-entry choice, its summary and the unset messages reworded).
No conflicts.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Harshi Shah <harshi.shah@contentstack.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants