Repository navigation
fix(variables): reword the manual entry choice, its summary and the unset messages (+Claude) - #253
Merged
Merged
Conversation
…nset messages Feedback on the variables wording: - The checklist choice "Type KEY=VALUE pairs" is now "Manually add custom variables", V1's wording, in both the create and set checklists. Its question is shorter and shows the format by example: 'Enter variables separated by spaces (Ex: KEY1=value1 KEY2:value2 KEY3="value with spaces")'. A test reads that example out of the question and checks it parses as shown. - Pairs entered at that prompt were labelled --var in the summary, as if the flag had been used. They now read "N from manual entry" and "KEY overridden by manual entry"; values given with --var still read "N from --var". - unset now says 'Are you sure you want to remove the variable DEBUG from the "Default" environment?' and '✔ Variable DEBUG removed from the "Default" environment.', with "variables" for several keys. Keys keep their case. The .talismanrc checksums are refreshed for the ten changed files it flags (variable keys and prompt text, no secret). #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Sakshi Koli <sakshi.koli@contentstack.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
rohan-agrawal-cs
approved these changes
Oct 26, 2026
SakshiKoli-CS
approved these changes
Oct 26, 2026
SakshiKoli-CS
added a commit
that referenced
this pull request
Oct 26, 2026
Brings in #253 (the variables manual-entry choice, its summary and the unset messages reworded). No conflicts. #claude_code# 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Harshi Shah <harshi.shah@contentstack.com> Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wording feedback on the
launch:variablesflows (CL-7169):variables:set)Type KEY=VALUE pairsManually add custom variables(V1's wording)KEY=VALUE pairs separated by spacesEnter variables separated by spaces (Ex: KEY1=value1 KEY2:value2 KEY3="value with spaces")✔ 1 variable set — 1 from --var✔ 1 variable set — 1 from manual entry(override:KEY overridden by manual entry)--var✔ 1 variable set — 1 from --varunsetconfirmationAre you sure you want to remove DEBUG from "Default"?Are you sure you want to remove the variable DEBUG from the "Default" environment?unsetsuccess✔ DEBUG removed from Default.✔ Variable DEBUG removed from the "Default" environment.The prompt path used to label typed pairs
--var, as if the flag had been used. Now only the flag says--var. With several keys,unsetsays "variables" instead of "variable". Keys keep their case.Tests
--vardoesn't appear, and the--varflag tests still check for1 from --var.npm test: 139 suites, 2420 tests pass. Lint andtscpass./code-reviewran on the change:unsetconfirmation was reworded to match the success line.unsetVariablesalready deduplicates..talismanrcchecksums are refreshed for the ten changed files it flags.#claude_code#
🤖 Generated with Claude Code