Skip to content

feat(site): ask which domain to open with launch:site:open - #259

Merged
Harshi-Shah-CS merged 2 commits into
v2-devfrom
CL-8094
Oct 28, 2026
Merged

Harshi-Shah-CS merged 2 commits into
v2-devfrom
CL-8094

Conversation

@Harshi-Shah-CS

Copy link
Copy Markdown
Contributor

🤖 Opened by launch-developer-agent (Claude). Replies from this account are the AI agent too. Review stays human. Merge: by this agent once one human approves and checks pass, and not before Harshi comments on CL-8094 that local testing passed.

Jira: https://contentstack.atlassian.net/browse/CL-8094

Changes

Follow-up to #258 (updated change request, Jira comment 564740). On a terminal, launch:site:open now asks Which domain do you want to open? (single-select, default Launch URL first and preselected, labelled (default), then the environment's other domains as bare hostnames) when there are two or more distinct URLs, and opens only the one picked. Ctrl-C exits 3 and opens nothing. One URL: no prompt. There is no --domain flag (future scope).

Unchanged: no TTY prints the default URL only; --deployment opens its preview with no prompt; no deployment still prints Website URL not found. (exit 2); GET-only, environment read first. --help and README updated.

Testing Plan

  • npm test scoped to src/site, src/commands/launch/site, test/integration/site-open.test.ts, test/guards, src/deployments, test/integration/retired-commands.test.ts: green; eslint and tsc clean; Snyk hook and secrets scan ran.
  • Test plan: 24/24 scenarios covered.
  • QA: the Launch QA agent tests CL-8094 in the repos once it is in QA; GoCD sanity covers dev11.

Known Gaps

  • The REST environment response has no verification status, so the list can include a custom domain whose DNS isn't verified yet; domains are not hidden on that basis.
  • Prompt needs stdin and stdout on a terminal; stdout-only terminal opens the default as today.
  • Refreshed .talismanrc checksum for README.md: Talisman flagged low-severity existing flag prose already on v2-dev; no credentials.

Merge order: independent of other PRs.


Generated by Claude Code

On a terminal, with two or more URLs for the environment, launch:site:open now asks which
domain to open (single-select, default Launch URL first and preselected) and opens only that one.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RRzARAApuWRnrw4f4Ug8pU
Talisman flagged only low-severity prose in README.md (an existing flag description already on v2-dev); no credentials.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RRzARAApuWRnrw4f4Ug8pU
@Harshi-Shah-CS
Harshi-Shah-CS marked this pull request as ready for review October 28, 2026 17:04
@Harshi-Shah-CS
Harshi-Shah-CS requested review from a team as code owners October 28, 2026 17:04
@snyk-io

snyk-io Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 6 9 25 ✅ Passed
🟡 Medium Severity 0 4 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 9
  • Medium without fixes: 4
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@Harshi-Shah-CS Harshi-Shah-CS changed the title feat(site): ask which domain to open with launch:site:open (+Claude) feat(site): ask which domain to open with launch:site:open Oct 28, 2026
@Harshi-Shah-CS
Harshi-Shah-CS merged commit 80187de into v2-dev Oct 28, 2026
7 checks passed
@Harshi-Shah-CS
Harshi-Shah-CS deleted the CL-8094 branch October 28, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants