fix(jetbrains): decode percent-encoded spaces in FileUtils paths - #13206
Open
BetterAndBetterII wants to merge 1 commit into
Open
fix(jetbrains): decode percent-encoded spaces in FileUtils paths#13206BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
VfsUtilCore.urlToPath does not percent-decode, so file:// URIs with %20 created literal %20 directories for project .continue folders. Route path conversion through UriUtils.uriToFile / java.net.URI before VFS createDirectories/find, and cover Unity%20Projects in unit tests. Fixes continuedev#13134
BetterAndBetterII
requested review from
sestinj
and removed request for
a team
August 30, 2026 19:47
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JetBrains
FileUtils.writeFile/findFileconvertedfile://URIs withVfsUtilCore.urlToPathandrefreshAndFindFileByUrl.urlToPathonly strips the protocol — it does not percent-decode — so a project path likeC:\Unity Projects\My Projectbecame a literal filesystem directoryC:\Unity%20Projects\My%20Project\.continue.This routes path conversion through
UriUtils.uriToFile/java.net.URIso%20(and other percent-escapes) decode beforeVfsUtil.createDirectoriesand VFS find. The Windows two-slashfile://C:/...branch inUriUtils.parseUrinow parses the URI string instead of using the 4-argURIconstructor, which would re-encode%as%25.Tests
FileUtilsTest:writeFile/readFile/fileExistswithfile://.../Unity%20Projects/foo.txtcreate and read decodedUnity Projects/foo.txt, not a literalUnity%20Projectsdir.UriUtilsTest: Windowsfile://C:/Unity%20Projects/...path decodes to/C:/Unity Projects/....Fixes #13134