Bump to 1.0.1: loosen vertebrae dependency to allow 2.x - #19
Merged
Merged
Conversation
vertebrae 2.0.0 fixes a bug where the request path was built with a duplicated prefix, producing malformed URLs with multiple consecutive slashes for any client passing an already-absolute path (see controlshift/vertebrae#8). The previous ~> 1.0.5 pin blocked upgrading. Verified action_kit_rest's own spec suite (44 examples) passes unchanged against vertebrae 2.0.0.
ehimen-io
changed the title
ehimen-io
marked this pull request as ready for review
September 29, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vertebrae2.0.0 fixes a real URL-construction bug (duplicated prefix producing malformed paths with multiple consecutive slashes for any client passing an already-absolute path) — see controlshift/vertebrae#8, now published to rubygems.org. Note: that bug is not confirmed as the cause of the Tokyo Identity 403/409 error reports that originally prompted this — 38 Degrees has since shown the identical malformed URL succeeding elsewhere, so the real cause of those errors is still open. The vertebrae fix stands on its own merits regardless. It also raises the Ruby floor to 3.4 and pins Faraday to~> 2.0.vertebrae ~> 1.0.5pin blocks that upgrade downstream (e.g. intokyo, see controlshift/tokyo#1997). Loosening it to>= 1.0.5, < 3.0lets consumers pick up 2.0.0 without forcing an immediate bump here.Test plan
bundle exec rspecagainst vertebrae 2.0.0 (via a temporary git-tag override, reverted before commit) — 44 examples, 0 failuresbundle exec rubocop— no offensesbundle installresolves cleanly against the published 1.0.5 (unchanged default behavior)Release
Merged and released as v1.0.1, published to rubygems.org.
🤖 Generated with Claude Code