Handle JSON-LD @type arrays with multiple types - #134
Draft
sethherr wants to merge 1 commit into
Draft
Conversation
JSON-LD allows a node to declare multiple types (e.g. an author who is also the publishing org: ["Person", "Organization"]). Routing @type through val_or_first_item raised on those, aborting UpdateCitationMetadataFromRatingsJob. Pick the type this parser cares about instead, keeping val_or_first_item's raise as a canary for the case it actually guards. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a Honeybadger fault where
UpdateCitationMetadataFromRatingsJobaborted onRuntimeError: Array with multiple values: ["Person", "Organization"](fault 133052862)."@type": ["Person", "Organization"].MetadataJsonLdParserrouted@typethroughval_or_first_item, which raises on any array with more than one element.@typenow goes through atype_keythat picks the type this parser cares about (KEY_PRIORITYthenPUBLISHER_KEY_PRIORITY, falling back to the first listed), so the example above keys asOrganizationand becomes eligible forpublisher_name.val_or_first_item's raise is left alone — it still guards the case it was meant for, an array of full JSON-LD objects where picking one silently drops data.