Fix BMenuField AllDetached callback dispatch - #19
Open
cyberman wants to merge 1 commit into
Open
Conversation
Dispatch BMenuField::AllDetached to the matching Python override instead of AllAttached. Add a focused regression test that enters the C++ trampoline paths and verifies both detach callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PyBMenuField::AllDetached() dispatches to the Python AllAttached() override instead of AllDetached().
Fix
Use AllDetached as the trampoline target.
Validation
Verified that detaching through the bound base methods now invokes DetachedFromWindow() and AllDetached().