Skip to content

Fix BSeparatorView holder ownership #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyberman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BSeparatorView holder ownership #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/interface/SeparatorView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PyBSeparatorView : public BSeparatorView{

PYBIND11_MODULE(SeparatorView,m)
{
py::class_<BSeparatorView, PyBSeparatorView, BView>(m, "BSeparatorView")
py::class_<BSeparatorView, PyBSeparatorView, BView, std::unique_ptr<BSeparatorView, py::nodelete>>(m, "BSeparatorView")
.def(py::init<orientation, border_style>(), "", py::arg("orientation"), py::arg("border")=B_PLAIN_BORDER)
.def(py::init<const char *, const char *, orientation, border_style, const BAlignment &>(), "", py::arg("name"), py::arg("label"), py::arg("orientation")=B_HORIZONTAL, py::arg("border")=B_FANCY_BORDER, py::arg("alignment")=BAlignment(B_ALIGN_HORIZONTAL_CENTER,B_ALIGN_VERTICAL_CENTER))
.def(py::init<const char *, BView *, orientation, border_style, const BAlignment &>(), "", py::arg("name"), py::arg("labelView"), py::arg("orientation")=B_HORIZONTAL, py::arg("border")=B_FANCY_BORDER, py::arg("alignment")=BAlignment(B_ALIGN_HORIZONTAL_CENTER,B_ALIGN_VERTICAL_CENTER))
Expand Down
46 changes: 46 additions & 0 deletions tests/separatorViewHolderOwnership.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import gc
import faulthandler

faulthandler.enable()

try:
import resource
resource.setrlimit(resource.RLIMIT_CORE, (0, 0))
except Exception:
pass

from Be import (
BApplication,
BSeparatorView,
BRect,
BWindow,
B_HORIZONTAL,
B_NOT_RESIZABLE,
window_type,
)


application = BApplication(
"application/x-vnd.haiku-pyapi-bseparatorview-holder-test"
)

window = BWindow(
BRect(100.0, 100.0, 360.0, 260.0),
"BSeparatorView holder test",
window_type.B_TITLED_WINDOW,
B_NOT_RESIZABLE,
)

separator = BSeparatorView(B_HORIZONTAL)

window.AddChild(separator, None)
window.Quit()

del separator
gc.collect()

del window
del application
gc.collect()

print("BSEPARATORVIEW HOLDER OWNERSHIP REGRESSION TEST: PASS")