Skip to content

Fix BMenuItem shortcut default #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyberman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BMenuItem shortcut default #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/interface/MenuItem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ PYBIND11_MODULE(MenuItem,m)
//m.attr("MenuItemPrivate") = MenuItemPrivate;

py::class_<BMenuItem, PyBMenuItem, BInvoker, std::unique_ptr<BMenuItem, py::nodelete>>(m, "BMenuItem")
.def(py::init<const char *, BMessage *, char, unsigned int>(), "", py::arg("label"), py::arg("message"), py::arg("shortcut")=0, py::arg("modifiers")=0)
.def(py::init<const char *, BMessage *, char, unsigned int>(), "", py::arg("label"), py::arg("message"), py::arg("shortcut")='\0', py::arg("modifiers")=0)
.def(py::init<BMenu *, BMessage *>(), "", py::arg("menu"), py::arg("message")=NULL)
.def(py::init<BMessage *>(), "", py::arg("data"))
.def_static("Instantiate", &BMenuItem::Instantiate, "", py::arg("archive"))
Expand Down
23 changes: 23 additions & 0 deletions tests/menuItemShortcutDefault.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import gc

from Be import BMenuItem, BMessage


message = BMessage(0x716D6903)

item = BMenuItem(
"default shortcut",
message,
)

if item.Label() != "default shortcut":
raise RuntimeError(
f"unexpected menu item label: {item.Label()!r}"
)

del item
del message

gc.collect()

print("BMENUITEM DEFAULT SHORTCUT REGRESSION TEST: PASS")