luci-app-turboacc: fix Broadcom spelling#409
Merged
coolsnowwolf merged 1 commit intoJul 25, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the user-facing spelling of the Broadcom fullcone NAT mode label from Boardcom to Broadcom across LuCI TurboACC and Firewall UIs, and aligns the TurboACC RPC status string accordingly (without changing the underlying UCI values or detection logic).
Changes:
- Update the TurboACC RPCD backend to report
Broadcom Fullcone NAT1in the fullcone type string. - Update the TurboACC UI list value label for fullcone mode
2toBroadcom Fullcone NAT1. - Update the Firewall zones UI list value label for fullcone mode
2toBroadcom Fullcone NAT1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/luci-app-turboacc/root/usr/libexec/rpcd/luci.turboacc | Fix misspelling in reported fullcone type string for status output. |
| applications/luci-app-turboacc/htdocs/luci-static/resources/view/turboacc.js | Fix misspelling in the TurboACC UI list option label. |
| applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/zones.js | Fix misspelling in the Firewall UI list option label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
195
to
198
| if (features.hasXTFULLCONENAT || features.hasNFTFULLCONENAT) { | ||
| o.value('1', _('FULLCONENAT')); | ||
| o.value('2', _('Boardcom Fullcone NAT1')); | ||
| o.value('2', _('Broadcom Fullcone NAT1')); | ||
| } |
Comment on lines
68
to
72
| o = s.option(form.ListValue, 'fullcone', _('Enable FullCone NAT')); | ||
| o.value('0', _('Disable')); | ||
| o.value('1', _('FULLCONENAT')); | ||
| o.value('2', _('Boardcom Fullcone NAT1')); | ||
| o.value('2', _('Broadcom Fullcone NAT1')); | ||
| addTCPCCAOption(); |
Signed-off-by: hokyouni <61335738+hokyouni@users.noreply.github.com>
hokyouni
force-pushed
the
fix-broadcom-fullcone-spelling
branch
from
July 21, 2026 12:33
0d21e97 to
bdf3a02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Broadcom fullcone implementation uses the BCM naming throughout the kernel and firewall integration. Correct the misspelled
Boardcomuser-facing labels and status strings toBroadcom.The underlying UCI option values and fullcone detection logic are unchanged.
Update the TurboACC translation template and Simplified Chinese catalog to keep the corrected msgid translated. Remove two stale duplicate
Boardcom fullconeentries that causedmsgfmtvalidation to fail.Tested:
npx eslint applications/luci-app-firewall/htdocs/luci-static/resources/view/firewall/zones.js applications/luci-app-turboacc/htdocs/luci-static/resources/view/turboacc.jsnode --checkon both changed JavaScript filesmsgfmt --check --check-compatibilityon the Simplified Chinese catalog./build/i18n-scan.plfor both affected applicationsgit diff --checkBoardcomreferences remain in either affected application