Repository navigation
Add explicit socket shutdown and close operations. - #31
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
feat/socket-lifecycle
branch
from
October 17, 2026 12:59
3ad9279 to
8be91b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add directional socket shutdown, consuming socket close, and their admission-only
_submitvariants toSocket. Implement the same contract for native, Tokio, io_uring, and simulated backends, with a commented request/response half-close example.Cleanup reuses the bounded pool and graceful draining already used for file close. Ordinary futures await completion and report execution errors;
_submitfutures await acceptance only. Shutdown borrows and privately retains the socket while accepted work runs. Close consumes exclusive ownership and rejects outstanding backend use rather than cancelling or joining operations. Applications must finish or cancel-and-await outstanding work before closing.Socket close and shutdown currently use cleanup-pool syscalls even with io_uring selected; native SQEs remain a later optimization. Windows close preserves positive linger by switching the deregistered socket to blocking mode on the cleanup worker. Shared conformance and lifecycle tests cover half-close, pending reads, cancellation, admission, abandonment, and shutdown draining.