Repository navigation
Split file capabilities and clarify scheduler trait names. - #40
Merged
samuel-williams-shopify merged 2 commits intoOct 18, 2026
Merged
Conversation
samuel-williams-shopify
deleted the
refactor/file-operation-capabilities
branch
October 18, 2026 03:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic file consumers can now require individual operations, such as
FileRead + FileWrite, without requiring a backend to implement the entire file interface. Name the broad interfacesFileSchedulerandSocketSchedulerto distinguish the scheduler capabilities from their resources.Introduce
FileOperationfor the shared associated resource type and split the core file operations into independent traits.FileStatowns the metadata output type;FileAdviceandFileAllocatedepend only on the shared base.FileScheduleris an automatically implemented aggregate, with ordinary and_submitforms grouped in their operation trait. Rename the existingSockettrait toSocketScheduler; its operation-level split remains separate follow-up work. Native, Tokio, and simulated backends preserve their existing operation behavior.This changes the public implementor interface: implement individual file traits instead of
File, move fully qualified associated-type paths toFileOperation/FileStat, and import operation traits for method calls on concrete schedulers. Rename broad bounds and imports toFileScheduler/SocketScheduler, and socket implementations toimpl SocketScheduler. Update modules, exports, examples, shared contracts, release notes, and migration guidance. Partial backends and compile-time checks exercise the smaller capability requirements. RecordSocketOperationas the agreed base name for the separate socket refactor.