Skip to content

ci: add override-size-check label to skip binary size enforcement#2246

Open
prestist wants to merge 1 commit into
coreos:mainfrom
prestist:override-size-check
Open

ci: add override-size-check label to skip binary size enforcement#2246
prestist wants to merge 1 commit into
coreos:mainfrom
prestist:override-size-check

Conversation

@prestist

@prestist prestist commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

There might be some edge cases where we want an override. lets add a lable for it like "skip-notes"

Summary by CodeRabbit

  • Chores
    • Binary size validation now responds to pull request label changes.
    • Authorized maintainers can apply the override-size-check label to bypass the binary size threshold when appropriate.
    • Removing the label re-enables normal binary size validation.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: 7d7030ec-b58a-47dc-ae6f-07a8a0782d7d

📥 Commits

Reviewing files that changed from the base of the PR and between 4e9026c and 8250775.

📒 Files selected for processing (1)
  • .github/workflows/binary-size.yml

📝 Walkthrough

Walkthrough

The binary size workflow now runs when pull request labels change and bypasses threshold enforcement when the override-size-check label is present.

Changes

Binary size workflow

Layer / File(s) Summary
Label-triggered size check override
.github/workflows/binary-size.yml
The workflow handles labeled and unlabeled pull request events and skips excessive-growth enforcement when override-size-check is present.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding an override label to bypass binary size enforcement in CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Binary size report (bin/amd64/ignition)

Size
Base (main) 21MiB
PR (#2246) 21MiB
Delta +0B (0.00%)

@prestist prestist added the skip-notes This PR does not need release notes label Jul 17, 2026

@angelcerveraroldan angelcerveraroldan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should probably stop code rabbit from editing out comments.

@prestist

Copy link
Copy Markdown
Collaborator Author

We should probably stop code rabbit from editing out comments.

hmm, I think I agree. you mean the summary edit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants