ci: add override-size-check label to skip binary size enforcement#2246
Open
prestist wants to merge 1 commit into
Open
ci: add override-size-check label to skip binary size enforcement#2246prestist wants to merge 1 commit into
prestist wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe binary size workflow now runs when pull request labels change and bypasses threshold enforcement when the ChangesBinary size workflow
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Binary size report (
|
| Size | |
|---|---|
Base (main) |
21MiB |
| PR (#2246) | 21MiB |
| Delta | +0B (0.00%) |
angelcerveraroldan
approved these changes
Jul 17, 2026
angelcerveraroldan
left a comment
Member
There was a problem hiding this comment.
LGTM
We should probably stop code rabbit from editing out comments.
Collaborator
Author
hmm, I think I agree. you mean the summary edit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be some edge cases where we want an override. lets add a lable for it like "skip-notes"
Summary by CodeRabbit
override-size-checklabel to bypass the binary size threshold when appropriate.