Skip to content

chore: align YAML dependencies with go-ftw#64

Draft
Copilot wants to merge 2 commits into
mainfrom
copilot/remove-goccy-go-yaml
Draft

chore: align YAML dependencies with go-ftw#64
Copilot wants to merge 2 commits into
mainfrom
copilot/remove-goccy-go-yaml

Conversation

Copilot AI commented May 2, 2026

Copy link
Copy Markdown

goccy/go-yaml was previously removed (#28), but the repo still diverged from go-ftw's current yaml stack. This aligns the two.

Changes

  • Switch to go.yaml.in/yaml/v4 in test files — matches the library go-ftw uses to parse FTW YAML files today
  • Remove projectdiscovery/yamldoc-go — was never directly imported in Go source; go mod tidy correctly drops it. gopkg.in/yaml.v3 is retained as an indirect dep via transitive dependencies
  • Remove broken doc-generation infrastructure — the generated files (test_doc.go, overrides_doc.go) were never committed, making the whole pipeline non-functional:
    • Drop //go:generate dstdocgen directives from types/types.go and types/overrides/types.go
    • Remove cmd/generate-doc-yaml-schema
    • Remove Generate() and Markdown() mage targets; Test() and Format() no longer depend on Generate()

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/coreruleset/go-ftw/contents/go.mod
    • Triggering command: /usr/bin/curl curl -s REDACTED 0.1-go1.25.7.lin-I conf�� 0.1-go1.25.7.lin--gdwarf-5 0.1-go1.25.7.lin--64 rg/toolchain@v0.-o pull.rebase (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 2, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented May 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c097fe75-f8c9-4bb4-88ab-d9016cc7ee6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/remove-goccy-go-yaml

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Remove goccy/go-yaml to align with go-ftw chore: align YAML dependencies with go-ftw May 2, 2026
Copilot finished work on behalf of fzipi May 2, 2026 17:12
Copilot AI requested a review from fzipi May 2, 2026 17:12
@fzipi

fzipi commented May 2, 2026

Copy link
Copy Markdown
Member

🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove goccy/go-yaml

2 participants