Update cran-comments to match the current check - #106
Merged
Conversation
The title-case and NEJM-URL notes were resolved in the check-notes fix (Title is now 'Learn-as-You-Go' and man/BB_data.Rd uses the DOI form), so drop their explanations from the incoming-feasibility note. The remaining findings are the expected 'New submission' note plus the local conda '-march=nocona' note and the missing-qpdf warning, none of which occur on CRAN's machines.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Updates
cran-comments.mdto match the currentR CMD check --as-cranoutput.The title-case and NEJM-URL notes were resolved in the check-notes fix (the
DESCRIPTION Title is now
Learn-as-You-Goandman/BB_data.Rduses the DOIform), so their explanations are dropped from the incoming-feasibility note.
What remains documented is exactly what the check now reports: the expected
New submissionnote, plus the local conda toolchain's-march=noconanon-portable-flag note and the missing-
qpdfwarning — none of which occur onCRAN's build machines.
Related issue
CRAN-submission prep (follows the check-notes fix).
Checklist
tests/testthat/. Submission-note text only,no code change.
devtools::document()run. No roxygen change.devtools::check()passes locally. Unchanged since the prior clean check;cran-comments.mdis not part of the built package.NEWS.mdupdated. Not needed: submission metadata, no user-facing change.