Repository navigation
Conversation
… checkout dirs build
|
Thanks for this. Confirmed: with the change, a full This check enforces that the OpenCode 2 TUI never imports credential-handling code, so it needs to fail closed. Slicing from the last
Separately, the TUI-wide check in |
|
Addressed in
|
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
|
Thanks — verified on a trial merge onto our current release: the full |
checkGaGraph and auditGraph now compare paths relative to the package root and refuse a path outside it, so a checkout under a directory named antigravity, plugin, hooks or rpc builds, and a nested src directory inside a forbidden folder can no longer slip past the credential-isolation check. Every caller passes the root it checks: the build passes its admitted package root, and the pack smoke passes the extracted package's own root. Co-authored-by: Marcos Santanna <2573094+mv2sa@users.noreply.github.com>
|
Thank you for this fix and for working through the review. It shipped in 3.0.14 (https://github.com/cortexkit/antigravity-auth/releases/tag/v3.0.14), squashed into our release branch with you credited as co-author ( |
Fixes #46
Summary
checkGaGraphinpackages/opencode/scripts/build-tui.tstests each audited file path againstGA_FORBIDDEN_SOURCE(/\/(?:rpc|plugin|antigravity|hooks)\/|.../). Becausegraph.filescontains absolute paths, cloning the repository into a directory namedantigravitycauses every file in the package to match/antigravity/on the checkout folder name and failbun run build.Changes
/src/segment before testingGA_FORBIDDEN_SOURCE, so directory names abovesrc/do not collide with package-internal forbidden directories.packages/opencode/scripts/build-tui.test.ts(graph.ga_policy_refusals).Verification
bun run buildinside a checkout directory namedantigravity/(0 errors)bun test --isolate packages/opencode/scripts/build-tui.test.ts -t "graph.ga_policy_refusals"bun x @biomejs/biome check packages/opencode/scripts/build-tui.ts packages/opencode/scripts/build-tui.test.ts