Repository navigation
feat(app): back and forward through the places you've been (BRA-2200) - #176
Merged
Merged
Conversation
The window strip's arrows, ⌘[ and ⌘], and a mouse's back and forward buttons walk a trail of the places you've been: a view, or in the workspace the worktree in front and its tab. The trail follows the view and workspace stores, so nothing that moves you has to report it. When the worktree in front is archived or removed you go back to the last place that is still there (the Agent Dashboard, say) instead of Home, and the dashboard keeps its scroll position. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Stener1 is attempting to deploy a commit to the seanbrydonio's projects Team on Vercel. A member of the Team first needs to authorize it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When you close a session and archive its worktree, you land on Home. To get back to the Agent Dashboard you go through the sidebar again, then scroll to find your place. This adds browser-style Back and Forward.
lib/nav-history.ts, pure partlib/nav-history-core.ts). A place isuseStore.view, and in the workspace the worktree in front (useWorkspaces.current) with its tab. The trail is recorded by subscribing to those two stores, so nosetViewcaller changes. Nothing is recorded while Back or Forward restores a place. Visiting the place you're on only updates its detail (tab, section), so Back doesn't walk through every tab. The trail holds 50 places and lasts until the window closes. Back and Forward skip places whose worktree is gone.components/sidebar/back-forward.tsx), and are disabled when there's nowhere to go. They're also on ⌘[ and ⌘] (Ctrl in the Linux app) and a mouse's back and forward buttons. They're inshortcuts.json, so they show in the Keyboard shortcuts sheet, ⌘K and the Mac app's Go menu. In a File tab's or SQL editor, ⌘[ and ⌘] stay outdent and indent. When the Mac menu bar takes the key first,use-shortcuts.tshands it to the editor.forgetWorktreedrops the workspace in front and you'd land on Home, you go back to the last place before it that still exists. With Labs tab groups, if another group comes forward instead, it stays in front as before.Evidence
Driven with the verify skill's new
navigation-historyscenario: the production build on the mock fixtures, in Chromium, with no console errors. It also passes with Labs on (labs=1).The scenario's steps:
Checks:
pnpm typecheck:plugins,check:titles,check:type,check:grid,check:csp,check:themes,pnpm test(572 pass, including 8 innav-history-core.test.ts),pnpm build,npx tsc -p e2eand(cd docs-site && pnpm build)all pass. In the browser, the newe2e/back-forward.spec.tspasses, and so dodashboard-*,sidebar-rail,sidebar-list,sidebar-columnsandworktree-remove(34 tests).cargo checkcouldn't run on this Linux box (no GTK dev libraries), but there's no Rust change. muda parsesCmdOrCtrl+[andCmdOrCtrl+]. There's no Go change.Review: Codex review and adversarial review raised three findings, and all three are fixed:
A Codex re-review found nothing further.
Not shown on the mock, so it needs a person in the Mac app:
mouseupwith buttons 3 and 4)The verify skill gets
features/navigation-history.md, a row infeatures/README.mdandscripts/scenarios/navigation-history.mjs. There's a changelog bullet under Unreleased and a line in Getting started.Linear: BRA-2200
🤖 Generated with Claude Code