Skip to content

fix(file): use path.Join instead of filepath.Join for object storage keys (#629) - #644

Open
teddiesloco wants to merge 1 commit into
coze-dev:mainfrom
teddiesloco:fix/windows-object-storage-keys
Open

fix(file): use path.Join instead of filepath.Join for object storage keys (#629)#644
teddiesloco wants to merge 1 commit into
coze-dev:mainfrom
teddiesloco:fix/windows-object-storage-keys

Conversation

@teddiesloco

Copy link
Copy Markdown

Summary

Fixes #629.

UploadLoopFile and UploadFileForServer were using filepath.Join to construct object-storage keys. On Windows platforms, this injected backslashes (\) into S3/object storage keys instead of the standard portable forward slashes (/).

This PR:

  • Replaces filepath.Join with URL/slash-oriented path.Join for object-storage key formatting in backend/modules/foundation/domain/file/service/server.go.
  • Ensures key path format is consistent across Windows, macOS, and Linux.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Object storage upload keys use backslashes on Windows

2 participants