Skip to content

Fixes #207: Can no longer parse RSA private keys with additional text #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timlegge wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #207: Can no longer parse RSA private keys with additional text #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RSA.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ sub new_private_key {
croak "unrecognized key format: expected PEM-encoded key (starting with '-----BEGIN') "
. "or DER-encoded key (binary ASN.1 data)"
unless defined $p_key_string && length($p_key_string) > 0;
if ( $p_key_string =~ /^-----/ ) {
if ( $p_key_string =~ /-----/m ) {
return $proto->_new_private_key_pem($p_key_string, @rest);
}
elsif ( substr($p_key_string, 0, 1) eq "\x30" ) {
Expand Down
21 changes: 21 additions & 0 deletions t/parse_text_key.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
use strict;
use warnings;

use Crypt::OpenSSL::RSA;
use File::Temp qw/tempfile/;
use Test::More;

diag ("Version: $Crypt::OpenSSL::RSA::VERSION");

my ($priv_fh, $priv_file) = tempfile(UNLINK => 1);

my $priv = `openssl genrsa -out $priv_file 2>&1`;
my $priv_text = `openssl rsa -in $priv_file -text 2>&1`;

my $rsa = eval {
Crypt::OpenSSL::RSA->new_private_key ($priv_text);
};

ok (defined ($rsa)) or diag ($@);

done_testing;
Loading