Skip to content

Add support for BoringSSL #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boris-Rasin wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −0
Open

Add support for BoringSSL #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/openssl/src/openssl_stream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,9 @@ class openssl_native_context : public native_context_base

if (!cd.ciphersuites.empty())
{
#ifndef OPENSSL_IS_BORINGSSL

@vinniefalco vinniefalco Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corosio does not have build configurations (no macros). This would have to be in a separate translation unit.

@Boris-Rasin Boris-Rasin Feb 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works when corosio does find_package(OpenSSL) and gets BoringSSL instead.
The macro gets there through #include <openssl/ssl.h>
I tested with my package manager which does this, and it works.

@vinniefalco vinniefalco Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it, of course it works. What I'm saying is that we don't use conditional compilation to change the nature of the binary on a specific platform. Every Capy library has to be the same. There's no "#if SINGLE_THREADED_MUTEX" or that stuff.

SSL_CTX_set_security_level(ctx_, 0);
#endif
SSL_CTX_set_cipher_list(ctx_, cd.ciphersuites.c_str());
}
}
Expand Down