Repository navigation
Drop cql-execution skips for tests that now pass, and relabel DateTimeToString2 - #149
Open
bryantaustin13 wants to merge 1 commit into
Open
bryantaustin13 wants to merge 1 commit into
bryantaustin13 wants to merge 1 commit into
Conversation
…eToString2 Run against the cql-execution test-server with every skip removed, four skipped tests already pass on main: ExpandPerHour and ExpandPerHourOpen (skipped for #94) and the two ExpandPerHour IntervalOverload tests (skipped for #135, which has merged). The TestInNullBoundaries entry points at a test cql-tests #116 replaced with TestIntegerInMaxIntervalTrue and TestIntegerInUnknownIntervalNull, which both pass. All five entries are removed. DateTimeToString2 was skipped as #84, but it still fails with #145: the test expects a DateTime string without an offset, which is cql-tests #73. Its reason now says so, so it stays skipped when the #84 skips go. On cql-execution: 1692 -> 1696 pass, 86 -> 82 skip, failures unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
conf/cql-execution-local.jsonskips some tests whose cause is already fixed onmain, and one entry points at a test that no longer exists. I ranmainagainst the cql-executiontest-server(cql-execution 4.0.0-beta.1, cql-testsf591d9e, the commitmainpins) with every skip removed, and checked each entry.mainwith the skip removedExpandPerHour,ExpandPerHourOpenInterval<Time>)ExpandPerHourIntervalOverload,ExpandPerHourOpenIntervalOverloadtime-precision; merged)TestInNullBoundariesTestIntegerInMaxIntervalTrueandTestIntegerInUnknownIntervalNull, which both passDateTimeToString2is skipped as #84 (DateTime with vs without an offset), but #84 isn't the cause. With #145 applied, the test still fails: the result is the string'2000-01-01T15:25:25.300+00:00'and the test expects no offset. That's cqframework/cql-tests#73. Left as it is, removing the #84 skips after #145 merges would turn this one into a failure.Change
conf/cql-execution-local.jsononly:DateTimeToString2toInvalid Test: Wrong Expected Outcome for ToString of DateTime with No Offset Specified: https://github.com/cqframework/cql-tests/issues/73. It stays skipped.The other skips are left alone:
ExceptTime2,ExceptTimeInterval) are fixed by Equate open and closed Time interval boundaries #148.RolledOutIntervalsis removed in Update cql-tests to 9e92193 and stop skipping RolledOutIntervals on cql-execution #147.Each of those can go once its PR merges.
Verification
Same server and tests:
mainThe only status changes are the 4 tests above, skip → pass.
DateTimeToString2is still skipped, with the new reason. The diff also applies cleanly on top of #147.cql-tests#69 can probably be closed, since the test it describes was replaced.
🤖 Generated with Claude Code