Skip to content

Handling of system.long addressed - #96

Closed
bryantaustin13 wants to merge 7 commits into
cqframework:mainfrom
bryantaustin13:skipForR4LongNotSupported
Closed

bryantaustin13 wants to merge 7 commits into
cqframework:mainfrom
bryantaustin13:skipForR4LongNotSupported

Conversation

@bryantaustin13

Copy link
Copy Markdown
Contributor

No description provided.

@brynrhodes brynrhodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great that it uses the capability statement to get the fhir version, but skipping

@cmoesel

cmoesel commented Apr 23, 2026 •

Copy link
Copy Markdown
Member

@brynrhodes - Why should we skip tests with Longs for R4? There is a mapping for CQL Long to R4. Given that the mapping exists and is R4-compliant, there is no reason a compliant CQL server could not return Long results in R4 (and, in fact, the javascript engine does).

The real problem is that the test runner doesn't correctly detect equality for Longs. See #79.

@bryantaustin13 bryantaustin13 changed the title Skip tests with Longs for R4 and earlier Handling of system.long addressed Apr 24, 2026
@bryantaustin13

bryantaustin13 commented Apr 24, 2026 •

Copy link
Copy Markdown
Contributor Author

See cqframework/clinical_quality_language#1750 for engine handling of R4 system.long. This branch should handle the cases of the different FHIR and CQL versions in regards to system.long. So it is currently failing for R4.

@bryantaustin13 bryantaustin13 mentioned this pull request Apr 28, 2026
@bryantaustin13

Copy link
Copy Markdown
Contributor Author

Superseded by #120. Now that I have committer access on cqframework/cql-tests-runner, this work has moved to a branch on the repository itself (same branch name, skipForR4LongNotSupported) so CI and reviews run here directly. Closing in favour of #120 — please continue any discussion there.

Note the approval on this PR predates #106 and #110 and should not carry over — #120 needs re-scoping against current main first.

@bryantaustin13
bryantaustin13 deleted the skipForR4LongNotSupported branch August 17, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants