Skip to content

Mark results of type Decimal without decimal places explicitly as type=decimal - #151

Draft
dehall wants to merge 1 commit into
cqframework:mainfrom
dehall:output_type_decimal
Draft

dehall wants to merge 1 commit into
cqframework:mainfrom
dehall:output_type_decimal

Conversation

@dehall

@dehall dehall commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

For detailed context on this PR, see Zulip thread here: #cql > Ambiguous Decimal/Integer Literals in Spec and Tests

In short, tests whose expected result is a Decimal without any decimal places are currently represented ambiguously. In some tests, the result is numeric without any decimal places, but technically that represents an Integer literal, not a Decimal. Alternatively, some tests use a Decimal literal, but doing so adds decimal places and implies a precision which should not be present in the final value.

This PR attempts to standardize by using the type parameter on the output, only on tests where the expected result is a Decimal with no decimal places.

Specifically:

@dehall

dehall commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Discussed at connectathon breakout session: the tests where the expected type changed between 1.5.3 and 2.0.0 need to be versioned, so I'll update those

@dehall
dehall marked this pull request as draft September 19, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant