Conversation
i-just
requested review from
brandonkelly and
brianjhanson
and removed request for
brandonkelly
September 24, 2026 10:35
brianjhanson
approved these changes
Sep 25, 2026
Contributor
Author
|
closing in favour of #628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrap registering CKEditor imports in
View::EVENT_BEGIN_PAGEso that the order in which Craft’s plugins are loaded does not affect whether the CKEditor plugin registered from it will be registered or not.(I initially wanted to wrap that registration in
Craft::$app->onInit(), but that wouldn’t fix this issue for anyone who registered their CKEditor package via it.)Steps to reproduce:
aaa) and the other a handle that’s after (ddd)$toolbarItems, but useAaaPluginTestandDddPluginTestfor the$pluginNamesrespectively(adjust for the
dddplugin)Uncaught TypeError: The specifier “@iwona/ddd” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with “./”, “../” or “/”.(the same will happen if you try to edit an entry that has a CKEditor field)
Related issues
#621