[8874] Long filenames/internal names expand card height and break grid row alignment in Select an Item browse dialog - #8992
Conversation
…d row alignment in Select an Item browse dialog
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe media card header now uses MUI ChangesMedia Card Header
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This update truncates media-card titles and limits subheaders to two lines while retaining path tooltips, preventing long names from disrupting grid alignment. No current merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai how does this work look to be merged? Any issues you can point out? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== Pull request metadata =="
gh pr view 8992 --repo craftersoftware/craftercms --json number,title,state,isDraft,baseRefName,headRefName,mergeable,reviewDecision,statusCheckRollup,files
echo
echo "== Pull request diff =="
gh pr diff 8992 --repo craftersoftware/craftercms -- studio-ui/ui/app/src/components/MediaCard/MediaCard.tsx || \
gh pr diff 8992 --repo craftersoftware/craftercms
echo
echo "== Component outline =="
ast-grep outline studio-ui/ui/app/src/components/MediaCard/MediaCard.tsx --items all || true
echo
echo "== Component source =="
cat -n studio-ui/ui/app/src/components/MediaCard/MediaCard.tsx
echo
echo "== Dependency manifests =="
fd -a -t f '^package\.json$' studio-ui/ui 2>/dev/null | while IFS= read -r f; do
echo "--- $f"
rg -n -i -C2 '"`@mui/material`"|"`@mui/system`"|"`@material-ui/core`"' "$f" || true
done
echo
echo "== Focused tests and component usages =="
rg -n -i -C3 '\bMediaCard\b|<CardHeader\b|lineClamp|WebkitLineClamp' studio-ui/ui/app \
-g '*.{ts,tsx,js,jsx}' -g '*.{test,spec}.*' || trueLength of output: 39668
Travis CI passed. The PR is mergeable. Before merge, remove the draft state and obtain the required review approval. A final manual check should use a very long filename and path in the “Select an Item” dialog. This check confirms the CSS behavior in the supported browsers. You are interacting with an AI system. |
#8874
Summary by CodeRabbit