[LangChain] Fix testing Jupyter Notebook vector_search.ipynb - #98
Merged
Conversation
amotl
force-pushed
the
amo/langchain-tests-vector-search
branch
from
October 29, 2023 22:50
6da6ccf to
50c28d6
Compare
vector_search.ipynbvector_search.ipynb
amotl
force-pushed
the
amo/langchain-tests-vector-search
branch
from
October 29, 2023 22:56
50c28d6 to
1e5486a
Compare
Contributor
Author
Problem-- https://github.com/crate/cratedb-examples/actions/runs/6686252645/job/18165405211?pr=98#step:5:558 References |
amotl
force-pushed
the
amo/langchain-tests-vector-search
branch
4 times, most recently
from
October 29, 2023 23:56
06bef0f to
d679aee
Compare
Contributor
Author
|
Works. 🚀 -- https://github.com/crate/cratedb-examples/actions/runs/6686545401/job/18166024142?pr=98#step:5:470 |
vector_search.ipynbvector_search.ipynb
amotl
marked this pull request as ready for review
October 30, 2023 00:29
amotl
requested review from
ckurze and
seut
and removed request for
hlcianfagna and
seut
October 30, 2023 11:13
1 task
amotl
force-pushed
the
amo/langchain-tests
branch
from
October 30, 2023 15:58
fb462c9 to
b246364
Compare
amotl
force-pushed
the
amo/langchain-tests-vector-search
branch
from
October 30, 2023 16:01
d679aee to
249d6ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Building upon the test infrastructure added with GH-97, this patch intends to fix a few last flaws within the Jupyter Notebook
vector_search.ipynb, primarily to make the software tests succeed.It also invokes corresponding tests on CI/GHA now.
/cc @ckurze, @WalBeh