Skip to content

Tests: Remove obsolete Python version skips - #299

Merged
bgunebakan merged 1 commit into
crate:mainfrom
nightcityblade:fix/issue-271-replacement-20260817
Aug 18, 2026
Merged

Tests: Remove obsolete Python version skips#299
bgunebakan merged 1 commit into
crate:mainfrom
nightcityblade:fix/issue-271-replacement-20260817

Conversation

@nightcityblade

Copy link
Copy Markdown
Contributor

Supersedes #296, which GitHub automatically closed after its source branch history was accidentally rewritten during follow-up. This replacement is rebuilt as one commit from current main and includes the requested review updates.

Fixes #271

Summary

  • remove obsolete Python 3.7 skip conditions now that the project requires Python 3.10+
  • retain the relevant SQLAlchemy, pandas, Dask, and Python 3.13 compatibility guards
  • allow the DataFrame doctest coverage to run on every supported Python version
  • apply the same Python 3.10+ cleanup to vector tests, dependency markers, and the DataFrame documentation

Validation

  • uv run poe lint
  • uv run pytest -q tests/bulk_test.py (2 passed, 3 skipped)
  • tests/test_support_pandas.py against CrateDB 6.5.0 (5 passed)
  • tests/integration.py against CrateDB 6.5.0 (6 passed)
  • python -m pytest tests/vector_test.py -k 'not integration' (11 passed, 1 deselected)
  • ruff format --check and ruff check on the changed Python test files
  • validate-pyproject pyproject.toml
  • make -C docs html
  • git diff --check

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a73be7d0-8b16-4366-9680-a761e508a2f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@florinutz florinutz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@bgunebakan bgunebakan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and especially for rebuilding it so cleanly after the branch
mishap, much appreciated, and no worries at all about the disruption.

@bgunebakan
bgunebakan merged commit 366977f into crate:main Aug 18, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove skipped tests for Python < 3.11

3 participants