modernize: fix cache key bug, drop committed token, node 18 + actions#1
Open
crazysoftwarecoder wants to merge 5 commits into
Open
modernize: fix cache key bug, drop committed token, node 18 + actions#1crazysoftwarecoder wants to merge 5 commits into
crazysoftwarecoder wants to merge 5 commits into
Conversation
it was built up front while body was still undefined, so POST requests with different bodies all shared one cache entry.
url-parse 1.1.1 -> 1.5.10 (security), mocha 3 -> 11, drop the coverage upload tooling. pin serialize-javascript via overrides to clear the mocha audit warning.
…tover dillinger line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing this one up to date and fixing a caching bug.
Bug fix
var body, so alwaysundefinedat that point). POST requests with different bodies collided on a single cache entry. Now the key is computed in theendhandler once the body is in.Security
.coveralls.yml). It should be rotated at coveralls.io; it stays in git history until/unless we scrub it.Deps + CI
url-parse1.1.1 -> 1.5.10 (1.1.1 has known advisories)mocha3 -> 11, droppedistanbul/coveralls/mocha-lcov-reporternpm audit: production deps clean (0); remaining 2 low are dev-only inside mocha's treeengines.node >= 18, committed a lockfile, test script no longer hardcodes the mocha pathREADME
Tests pass (
npm ci && npm test, 8 passing) on Node 18/20.