Feat/pgo v3

[henderkes]

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

• If you modified *.php or *.json, run them locally to ensure your changes are valid:
  • composer cs-fix
  • composer analyse
  • composer test
  • bin/spc dev:sort-config
• If it's an extension or dependency update, please ensure the following:
  • Add your test combination to src/globals/test-extensions.php.
  • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

[github-actions]

StaticPHP Test Bot

Detected: Extensions: fastchart, fastjson | Libraries: bzip2, fastlz, icu, imagemagick, jbig, krb5, libaom, libffi, libheif, liblz4, libpng, ncurses, openssl, postgresql, qdbm, unixodbc, watcher | Targets: llvm-compiler-rt, llvm-tools, php
Active labels: none
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

[henderkes]

(I tested with static-php/packages v3 branch, php 8.5 zig on rpm. Tests with Alpine and gcc are still to finish in a few hours when ci runs.)

[henderkes]

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

[crazywhalecc]

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

[henderkes]

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

Okay, added curl.exe on Windows too. Also figured out the root cause of the BUILD_CC patch minilua crash (zigs undefined behaviour sanitizer tripping up, if you run CC="clang -fsanitize=undefined" it will also fail) which coincidentally also fixed a possible edge case bug. BUILD_CC is also used for gen_ir so by using a different vm type it could have theoretically clashed.

[henderkes]

Oh, there's even an issue running the binaries despite no undefined sanitizer that I can't reproduce locally or in docker. Very weird.

[crazywhalecc]

How about subdir? build-root is definitely ambiguous. Also, move all the previous metadata.source-root here.

[henderkes]

build-dir?

subdir doesn't say what that directory is used for

[crazywhalecc]

Keep using source-root? build-dir sounds ambiguous too (out-of-source building). The name source-root also corresponds to our API getSourceRoot(). Although it still doesn't accurately describe our needs, it essentially redirects the source root.

[henderkes]

Two diffrremt things, we need both of them.

[crazywhalecc]

Another approach is to completely redirect everything using source-root, eliminating the need to worry about subdirectories during in-tree extension builds:

1. All artifacts are uniformly extracted to source/{name}
2. During static compilation of PHP extensions, a symbolic link is created to the root directory or the specified source-root to php-src/ext/{name}
3. Shared extensions remain unaffected

[crazywhalecc]

After doing this, our previous source-root and the current source-root for PHP extensions are actually the same thing.

[henderkes]

Are you sure that doesn't have edge cases with extension configs resolving to absolute paths before? If it's working with all extensions I think that's a good idea.