add binary file name in new release option#55
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 76.95% 77.10% +0.15%
==========================================
Files 28 28
Lines 1167 1166 -1
==========================================
+ Hits 898 899 +1
+ Misses 218 217 -1
+ Partials 51 50 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@creativeprojects, is there anything else I need to do here? |
|
Hi, thank you for this PR It's a good idea actually 😄 It's changing the signature of the exported methods. It means it's a breaking change: so it's not going to be a |
|
@creativeprojects oh, it looks like you're right. At the same time, updating the major version just for such a minor change is probably a bad idea. In that case, I suggest two options:
Overall, I can help with any of these options. What do you think? |
|
Option 2 looks quite neat. type UpdateToOpt struct {
Rel *Release
CmdPath string
}
func (up *Updater) UpdateTo(ctx context.Context, opt UpdateToOpt) error { ... } |
|
@creativeprojects okay, I'll take care of it. |
|
@creativeprojects I replaced parameters to options in all the major export methods/functions in a5c57b2. What do you think? |
Sometimes it is necessary to manually specify the name of the binary file in a new release (in which case, the target name and path will stay the same as for the "current" (old) executable). This PR implements this feature.
There are some breaking changes in the public API, so it's better to make a new minor version — v1.6.0.